Create a simple Overture example #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drabble
force-pushed
the
849-overture-example
branch
from
61b615c to
4ad9178
Compare
|
@Drabble Awesome, this is a nice start! |
bchapuis
reviewed
Jun 3, 2024
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetDataStore.java
Outdated
Show resolved
Hide resolved
baremaps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetDataTable.java
Outdated
Show resolved
Hide resolved
...maps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java
Show resolved
Hide resolved
...maps-core/src/main/java/org/apache/baremaps/storage/geoparquet/GeoParquetTypeConversion.java
Show resolved
Hide resolved
baremaps-core/src/main/java/org/apache/baremaps/workflow/tasks/ImportGeoParquet.java
Outdated
Show resolved
Hide resolved
bchapuis
reviewed
Jun 3, 2024
|
|
||
| // Iterate over all the files in the path | ||
| for (FileStatus file : fileSystem.globStatus(globPath)) { | ||
| files.put(file, buildFileInfo(file)); |
There was a problem hiding this comment.
Any reason why buildFileInfo got removed? You may need to rebase the branch.
There was a problem hiding this comment.
I think I was just using an old version and didn't merge correctly. I had to do a few fixes for S3 files to work. I will try to rollback tomorrow.
Drabble
force-pushed
the
849-overture-example
branch
from
4ad9178 to
55b2970
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java
Fixed
Show fixed
Hide fixed
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/data/GeoParquetGroupImpl.java
Fixed
Show fixed
Hide fixed
|
bchapuis
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to make a Overture maps example from Geoparquet files. I had to apply various dirty fixes to get it to run. These fixes need to be addressed before merging.
Here are a few examples of the vector tiles rendered in a browser.