Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Webhook] start_time field is required but Config-UI says it's optional #5097

Closed
2 of 3 tasks
hezyin opened this issue May 4, 2023 · 0 comments · Fixed by #5101
Closed
2 of 3 tasks

[Bug][Webhook] start_time field is required but Config-UI says it's optional #5097

hezyin opened this issue May 4, 2023 · 0 comments · Fixed by #5101
Assignees
Labels
type/bug This issue is a bug
Milestone

Comments

@hezyin
Copy link
Contributor

hezyin commented May 4, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Version: v0.17.0-beta3

This issue probably only requires some text update on the Config-UI side. Note how Config-UI suggests that start_time is optional in the following screenshot:

Screen Shot 2023-05-04 at 11 08 34 AM

But if I got the following error when I didn't pass start_time and I was able to succeed after passing start_time:
Screen Shot 2023-05-04 at 11 07 30 AM

When updating the curl command template, could you please also format it like below and use single quotation marks outside the curly braces so that we don't need to escape double quotation marks inside the payload?

Screen Shot 2023-05-04 at 11 08 37 AM

(this is from webhook plugin doc page: https://devlake.apache.org/docs/next/Plugins/webhook)

What do you expect to happen

See above

How to reproduce

See above

Anything else

No response

Version

main

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@hezyin hezyin added the type/bug This issue is a bug label May 4, 2023
@hezyin hezyin added this to the v0.17.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants