Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add java doc to dubbo-config-api #3103

Merged
merged 6 commits into from
Jan 2, 2019
Merged

add java doc to dubbo-config-api #3103

merged 6 commits into from
Jan 2, 2019

Conversation

lixiaojiee
Copy link
Contributor

What is the purpose of the change

add java doc to dubbo-config-api

Brief changelog

/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractMethodConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractServiceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ApplicationConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ArgumentConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ConsumerConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/MethodConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ModuleConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/MonitorConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProtocolConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProviderConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/RegistryConfig.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/invoker/DelegateProviderMetaDataInvoker.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ReferenceConfigCache.java
/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/MetadataReportConfig.java

#2993

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@lixiaojiee lixiaojiee mentioned this pull request Dec 30, 2018
6 tasks
@codecov-io
Copy link

codecov-io commented Dec 30, 2018

Codecov Report

Merging #3103 into master will increase coverage by 0.02%.
The diff coverage is 73.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3103      +/-   ##
============================================
+ Coverage     63.52%   63.54%   +0.02%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28183    28185       +2     
  Branches       4791     4791              
============================================
+ Hits          17902    17909       +7     
+ Misses         8023     8017       -6     
- Partials       2258     2259       +1
Impacted Files Coverage Δ Complexity Δ
...org/apache/dubbo/config/AbstractServiceConfig.java 95.77% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/ConsumerConfig.java 92.3% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/MonitorConfig.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/config/utils/ReferenceConfigCache.java 75% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/AbstractConfig.java 79.09% <ø> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 57.3% <ø> (-0.77%) 0 <0> (ø)
...ava/org/apache/dubbo/config/ApplicationConfig.java 82.71% <ø> (ø) 0 <0> (ø) ⬇️
...ain/java/org/apache/dubbo/config/ModuleConfig.java 86.84% <ø> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 36.36% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/RegistryConfig.java 82.35% <ø> (ø) 0 <0> (ø) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41408e...c0a7a4f. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented Jan 2, 2019

LGTM, but @lixiaojiee would you mind to solve the conflict? Thanks.

Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to solve conflict.

@lixiaojiee
Copy link
Contributor Author

LGTM, but @lixiaojiee would you mind to solve the conflict? Thanks.

done

@beiwei30 beiwei30 merged commit 95ebfe8 into apache:master Jan 2, 2019
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
* add config-api javadoc

* add dubbo-config-api javadoc

* update javadoc

* add dubbo-config-api java doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants