Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add twitter follow #3104

Merged
merged 4 commits into from
Dec 31, 2018
Merged

add twitter follow #3104

merged 4 commits into from
Dec 31, 2018

Conversation

lovepoem
Copy link
Member

What is the purpose of the change

add twitter follow

Brief changelog

README.md

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Dec 30, 2018

Codecov Report

Merging #3104 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3104      +/-   ##
============================================
+ Coverage     63.52%   63.56%   +0.03%     
  Complexity       75       75              
============================================
  Files           653      653              
  Lines         28210    28210              
  Branches       4794     4794              
============================================
+ Hits          17921    17931      +10     
+ Misses         8026     8016      -10     
  Partials       2263     2263
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-2.44%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 58.33% <0%> (+0.37%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.95% <0%> (+1.87%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 73.82% <0%> (+2.01%) 0% <0%> (ø) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.12% <0%> (+3.22%) 0% <0%> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 87.5% <0%> (+12.5%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0005166...fd1b0df. Read the comment docs.

@lovepoem lovepoem merged commit bdb78b8 into apache:master Dec 31, 2018
@lovepoem lovepoem deleted the add_twitter_Follow branch December 31, 2018 09:52
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants