Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #3122

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Fix compile error #3122

merged 1 commit into from
Jan 3, 2019

Conversation

biyuhao
Copy link
Member

@biyuhao biyuhao commented Jan 3, 2019

What is the purpose of the change

Fix compile error

Previous console output:

./mvnw clean install -DskipTests
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for
org.apache.dubbo:dubbo-demo-xml-consumer:[unknown-version]: Could not find
artifact org.apache.dubbo:dubbo-demo:pom:2.7.0-SNAPSHOT and
'parent.relativePath' points at wrong local POM @ line 19, column 13
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: org.apache.dubbo:dubbo-metadata-definition:jar -> duplicate
declaration of version ${project.parent.version} @
org.apache.dubbo:dubbo-metadata-report-api:[unknown-version],
/root/codes/incubator-dubbo/dubbo-metadata-report/dubbo-metadata-report-api/pom.xml,
line 71, column 21
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: com.google.code.gson:gson:jar -> duplicate declaration of
version (?) @ org.apache.dubbo:dubbo-metadata-report-api:[unknown-version],
/root/codes/incubator-dubbo/dubbo-metadata-report/dubbo-metadata-report-api/pom.xml,
line 76, column 21

Brief changelog

modify dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-consumer/pom.xml

Verifying this change

UT pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3122 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3122      +/-   ##
============================================
- Coverage     63.67%   63.55%   -0.13%     
  Complexity       75       75              
============================================
  Files           652      652              
  Lines         28190    28190              
  Branches       4784     4784              
============================================
- Hits          17950    17915      -35     
- Misses         7989     8017      +28     
- Partials       2251     2258       +7
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 69.23% <0%> (-12.83%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 73.52% <0%> (-11.77%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 80.48% <0%> (-4.88%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 55.81% <0%> (-2.33%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.15% <0%> (-2.02%) 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ebfe8...fc13d33. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit b7857f9 into apache:master Jan 3, 2019
@biyuhao biyuhao deleted the fix-build branch January 3, 2019 08:07
khanimteyaz pushed a commit to khanimteyaz/incubator-dubbo that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants