Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add AppendParametersComponent #3583

Merged
merged 2 commits into from
Mar 1, 2019
Merged

[Feature] add AppendParametersComponent #3583

merged 2 commits into from
Mar 1, 2019

Conversation

qinliujie
Copy link
Contributor

What is the purpose of the change

add AppendParametersComponent to dynamically add some parameters / check config

Brief changelog

  • add new SPI AppendParametersComponent
  • when ServiceConfig/ReferenceConfig init, AppendParametersComponents will init and check

@qinliujie qinliujie requested a review from chickenlj March 1, 2019 07:09
@codecov-io
Copy link

Codecov Report

Merging #3583 into 3.x-dev will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3583      +/-   ##
=============================================
+ Coverage      63.73%   63.77%   +0.03%     
  Complexity        75       75              
=============================================
  Files            655      656       +1     
  Lines          28437    28449      +12     
  Branches        4812     4812              
=============================================
+ Hits           18124    18143      +19     
+ Misses          8033     8025       -8     
- Partials        2280     2281       +1
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/config/AppendParametersComponent.java 0% <0%> (ø) 0 <0> (?)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.64% <100%> (+0.73%) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 55.23% <100%> (+0.47%) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
...apache/dubbo/common/config/ConfigurationUtils.java 40% <0%> (-8%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-2.26%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 48.95% <0%> (+1.04%) 0% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c549e...350c4f8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants