Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve NetUtils #3953

Merged
merged 4 commits into from
May 5, 2019
Merged

Conversation

lexburner
Copy link
Contributor

  1. filter network interface in NetUtils
  2. remove the useless attribute in ApplicationConfig

@ralf0131
Copy link
Contributor

Hi, I observed that the UT are failing, I've trigger a new build. If there is still error, please keep an eye on it and fix it.

@ralf0131
Copy link
Contributor

Hi, please resolve the UT failures.

@ralf0131 ralf0131 added the status/waiting-for-feedback Need reporters to triage label Apr 30, 2019
@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #3953 into master will decrease coverage by 0.25%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3953      +/-   ##
===========================================
- Coverage     63.85%   63.6%   -0.26%     
- Complexity       98     100       +2     
===========================================
  Files           713     720       +7     
  Lines         31481   31838     +357     
  Branches       5076    5113      +37     
===========================================
+ Hits          20102   20250     +148     
- Misses         9071    9270     +199     
- Partials       2308    2318      +10
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/config/ApplicationConfig.java 97.59% <ø> (+2.24%) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.67% <33.33%> (-0.31%) 0 <0> (ø)
...ava/org/apache/dubbo/common/utils/ClassHelper.java 0% <0%> (-69.1%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.14% <0%> (-0.74%) 0% <0%> (ø)
...che/dubbo/common/compiler/support/JdkCompiler.java 64.54% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/apache/dubbo/config/AbstractConfig.java 79.57% <0%> (ø) 0% <0%> (ø) ⬇️
...mon/serialize/java/CompactedObjectInputStream.java 64.28% <0%> (ø) 0% <0%> (ø) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 79.11% <0%> (ø) 0% <0%> (ø) ⬇️
...g/apache/dubbo/common/bytecode/ClassGenerator.java 61.53% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 60.07% <0%> (ø) 0% <0%> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fe93b...e561cd1. Read the comment docs.

@lexburner
Copy link
Contributor Author

fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants