-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve NetUtils #3953
improve NetUtils #3953
Conversation
lexburner
commented
Apr 29, 2019
- filter network interface in NetUtils
- remove the useless attribute in ApplicationConfig
…te in ApplicationConfig
Hi, I observed that the UT are failing, I've trigger a new build. If there is still error, please keep an eye on it and fix it. |
Hi, please resolve the UT failures. |
Codecov Report
@@ Coverage Diff @@
## master #3953 +/- ##
===========================================
- Coverage 63.85% 63.6% -0.26%
- Complexity 98 100 +2
===========================================
Files 713 720 +7
Lines 31481 31838 +357
Branches 5076 5113 +37
===========================================
+ Hits 20102 20250 +148
- Misses 9071 9270 +199
- Partials 2308 2318 +10
Continue to review full report at Codecov.
|
fixed now |