-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUBBO-3137]: step3, remove constants completely. #4053
Conversation
…nd remove Constants.java completely.
Codecov Report
@@ Coverage Diff @@
## master #4053 +/- ##
============================================
- Coverage 63% 62.99% -0.02%
- Complexity 543 544 +1
============================================
Files 757 756 -1
Lines 32570 32569 -1
Branches 5162 5162
============================================
- Hits 20521 20516 -5
- Misses 9684 9694 +10
+ Partials 2365 2359 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look my comment.
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcConstants.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
so, now we should move to step4, start to review any constants suitable to move back to its own module. |
What is the purpose of the change
issue #3137: step3, remove constants completely.
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.