Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3778]: Annotation mode cannot set service parameters in 2.7.0 #4060

Merged
merged 1 commit into from
May 15, 2019
Merged

[DUBBO-3778]: Annotation mode cannot set service parameters in 2.7.0 #4060

merged 1 commit into from
May 15, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

fix issue #3778

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Contributor

@mercyblitz mercyblitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #4060 into master will increase coverage by 0.11%.
The diff coverage is 10.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4060      +/-   ##
============================================
+ Coverage     62.95%   63.06%   +0.11%     
- Complexity      543      547       +4     
============================================
  Files           756      756              
  Lines         32559    32870     +311     
  Branches       5159     5250      +91     
============================================
+ Hits          20499    20731     +232     
- Misses         9698     9766      +68     
- Partials       2362     2373      +11
Impacted Files Coverage Δ Complexity Δ
.../CompatibleServiceAnnotationBeanPostProcessor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...annotation/ServiceAnnotationBeanPostProcessor.java 78.76% <22.22%> (-3.72%) 0 <0> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (-1%)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...bo/rpc/cluster/support/FailbackClusterInvoker.java 67.21% <0%> (-3.28%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeClient.java 85.47% <0%> (-1.3%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <0%> (-0.67%) 27% <0%> (ø)
...emoting/transport/grizzly/GrizzlyCodecAdapter.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ache/dubbo/common/constants/RemotingConstants.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/registry/sofa/SofaRegistry.java 85.58% <0%> (+0.9%) 25% <0%> (+1%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae669ea...65f49d5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants