-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Separate each jni wrapper to different files #2845
Comments
After issue 3077 completed, I will separate current JniWrapper.cc into different sub-dir, it will looks like below:
Any suggestions? @jinchengchenghh @zhztheplayer @rui-mo |
This sort of refactor is needed. The thing is that we should find a proper time to apply the change, since it may easily conflict with other pending PRs. |
Good point, I prefer do the refactor in weekend, before that, let's discuss the structure we expected. |
Also cc @ulysses-you @FelixYBW @zhouyuan |
I think make jni file name align with java class is good. The |
PlanEvaluatorJniWrapper -> VeloxJniWrapper Such mappings should be finally eliminated IIUC. We already had |
Description
JniWrapper.cc is too large and may be larger in the future, we could separate it into sub dirs when some stateful static variables be removed, and get benefits from readability and UT.
The text was updated successfully, but these errors were encountered: