Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] delta-mergetree support update/delete/upsert/insert in a more Delta-like way #4732

Closed
binmahone opened this issue Feb 21, 2024 · 1 comment · Fixed by #4733
Closed
Labels
enhancement New feature or request

Comments

@binmahone
Copy link
Contributor

binmahone commented Feb 21, 2024

Description

for delta-mergetree, the issue will :

  1. Refactor already supported insert feature, so that it works more like vanilla Delta. This also includes removing some long-existing unnecessary concepts like ClickhouseAnalysis, ClickHouseFileIndex, ClickhouseScan, etc. After this PR, it is also required that users to put "--conf spark.sql.extensions=io.delta.sql.DeltaSparkSessionExtension" into spark parameters.
  2. Based on the refactor, update/delete/upsert is also implemented.
  3. Add test cases for insert overwrite ( it seems naturally working)
  4. Fix bucket pruning not working when there's a filter on bucket column

Must do

to enable this feature, you must:

  1. --conf spark.sql.extensions=io.delta.sql.DeltaSparkSessionExtension
  2. --conf spark.executor.extraClassPath=${spark_home}/jars/gluten.jar --conf spark.driver.extraClassPath=${spark_home}/jars/gluten.jar, the reason is similar to https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-troubleshooting.md#incompatible-class-error-when-using-native-writer
@binmahone binmahone added the enhancement New feature or request label Feb 21, 2024
@binmahone binmahone changed the title [CH][Delta] refactor code to avoid copying too many files from Delta [CH] delta-mergetree support update/delete/upsert/insert in a more native delta way Feb 29, 2024
@binmahone binmahone changed the title [CH] delta-mergetree support update/delete/upsert/insert in a more native delta way [CH] delta-mergetree support update/delete/upsert/insert in a more Delta-like way Feb 29, 2024
@binmahone
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant