[GLUTEN-2362][CORE] Record Substrait modifications and remove arena option #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
changed the title
|
Run Gluten Clickhouse CI |
JkSelf
reviewed
Jul 18, 2023
| * Added `WindowRel`, added `column_name` and `window_type` in `WindowFunction`, | ||
| changed `Unbounded` in `WindowFunction` into `Unbounded_Preceding` and `Unbounded_Following`, and added WindowType([#485](https://github.com/oap-project/gluten/pull/485)). | ||
| * Added `output_schema` in RelRoot([#1901](https://github.com/oap-project/gluten/pull/1901)). | ||
| * Added `ExpandRel`([#519](https://github.com/oap-project/gluten/pull/519)). |
There was a problem hiding this comment.
Please change the ExpandRel link to #1361.
winningsix
reviewed
Jul 18, 2023
| nav_order: 4 | ||
| parent: Developer Overview | ||
| --- | ||
| # Substrait Modifications in Gluten |
There was a problem hiding this comment.
Do we need to mention the base version of Substrait?
There was a problem hiding this comment.
Added the base version.
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Record Substrait modifications and remove arena option.
(Fixes: #2362)
How was this patch tested?
Testing on CI.