[VL] Add RowToColumnarExec to FakeRowAdaptor when use velox native parquet write #2799
Conversation
…velox native parquet write Change-Id: If330f096a64a7127887733c71e39a370a185b62e
…velox native parquet write Change-Id: If2b813993e6bf245d9bb981b3c6a01951a630da4
…velox native parquet write Change-Id: I284e42f027273528077f5f6f1918c59fc625c691
…velox native parquet write Change-Id: I5addffdede5ab8c3d111dfc6b9e067177c7ef384
…velox native parquet write Change-Id: I8c8af6d1dffca25d1b87a0b47a2ee46ddd35c0a5
…velox native parquet write Change-Id: I8937f81767d343acb2e4dde14ada25b4ab1d5270
…velox native parquet write Change-Id: I4a9afa718dace1a6ccac221cae204065391ae968
…velox native parquet write Change-Id: I168510d8a9cf98dde8f044e96693fece54bc1313
…velox native parquet write Change-Id: I4ec20640bf2e7a3259ec2fa367927432bb02aadc
…velox native parquet write Change-Id: I546013b04d54b9f3e75fb183cba75dd3d8019480
…rquet write Change-Id: I3b23628f134515cb6f3da4128024566a98100312
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
| rc.withNewChildren( | ||
| Array( | ||
| FakeRowAdaptor( | ||
| BackendsApiManager.getSparkPlanExecApiInstance.genRowToColumnarExec(other)))) |
There was a problem hiding this comment.
Thanks for your PR!
I note doExecuteColumnar at FakeRowAdaptor has a similar handling for row-based child operator. Doesn't that piece of code work?
If there is any issue found in your test, could you please add some UTs? Thanks!
| case other => rc.withNewChildren(Array(FakeRowAdaptor(other))) | ||
| case other => | ||
| if (other.supportsColumnar) { | ||
| rc.withNewChildren(Array(FakeRowAdaptor(other))) |
There was a problem hiding this comment.
Please add some UTs to show why we should do this and confirm problem fixed.
|
@PHILO-HE I just checked the problem @WolverineJiang met. it has nothing to do with the current pr, he did not override the |
No problem. Thanks for your clarification! |
What changes were proposed in this pull request?
Some problems bring in by patch #1925 . This patch will resolve it.
How was this patch tested?
Run UT by set spark.gluten.sql.native.writer.enabled=true
Run TPCDS by set spark.gluten.sql.native.parquet.writer.enabled=true && spark.sql.sources.useV1SourceList=parquet