Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove ColumnarToRow for Gluten columnar table cache #3430

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

PHILO-HE
Copy link
Contributor

What changes were proposed in this pull request?

Remove unnecessary ColumnarToRow for table cache, as it is internally supported. Mentioned at #3368 (comment). Also includes some small code refactor.

How was this patch tested?

New UT.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@ulysses-you ulysses-you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@ulysses-you ulysses-you merged commit 7fbd3fc into apache:main Oct 18, 2023
14 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3430_time.csv log/native_master_10_17_2023_6daa1d678_time.csv difference percentage
q1 43.20 42.87 -0.337 99.22%
q2 24.21 24.66 0.449 101.85%
q3 38.00 38.25 0.249 100.66%
q4 42.20 41.71 -0.495 98.83%
q5 70.95 71.22 0.265 100.37%
q6 5.02 6.76 1.735 134.52%
q7 86.65 86.78 0.129 100.15%
q8 80.68 82.50 1.824 102.26%
q9 117.92 117.40 -0.517 99.56%
q10 45.91 48.17 2.257 104.92%
q11 19.47 20.11 0.633 103.25%
q12 26.27 24.79 -1.483 94.35%
q13 51.05 49.25 -1.802 96.47%
q14 14.79 18.04 3.245 121.94%
q15 26.20 28.10 1.894 107.23%
q16 15.93 15.84 -0.089 99.44%
q17 121.38 122.20 0.814 100.67%
q18 161.82 162.51 0.693 100.43%
q19 13.41 11.96 -1.448 89.20%
q20 25.31 29.50 4.183 116.53%
q21 236.27 235.77 -0.501 99.79%
q22 15.52 15.10 -0.421 97.29%
total 1282.20 1293.47 11.276 100.88%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants