Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][DOC] Refine the document about parquet write #3441

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Oct 19, 2023

What changes were proposed in this pull request?

Refine the document about parquet write.

How was this patch tested?

No need.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@JkSelf
Copy link
Contributor Author

JkSelf commented Oct 19, 2023

@zhouyuan Please help to review. Thanks.

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvement!

docs/velox-backend-limitations.md Show resolved Hide resolved
docs/velox-backend-limitations.md Outdated Show resolved Hide resolved
docs/velox-backend-limitations.md Outdated Show resolved Hide resolved
@JkSelf
Copy link
Contributor Author

JkSelf commented Oct 19, 2023

@zhouyuan Updated. Please help to review again. Thanks.

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhouyuan zhouyuan merged commit a9324e6 into apache:main Oct 19, 2023
5 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_10_19_2023_time.csv log/native_master_10_18_2023_4dbb181cc_time.csv difference percentage
q1 40.32 43.58 3.266 108.10%
q2 24.36 24.34 -0.018 99.93%
q3 40.92 35.79 -5.132 87.46%
q4 33.60 41.52 7.916 123.56%
q5 70.38 70.78 0.407 100.58%
q6 8.94 5.74 -3.207 64.15%
q7 102.14 86.23 -15.916 84.42%
q8 104.41 80.16 -24.248 76.78%
q9 156.04 117.35 -38.689 75.21%
q10 72.84 47.73 -25.115 65.52%
q11 22.07 20.15 -1.922 91.29%
q12 34.28 25.94 -8.344 75.66%
q13 72.13 49.65 -22.478 68.84%
q14 25.22 15.32 -9.901 60.74%
q15 40.39 27.13 -13.257 67.17%
q16 18.59 16.07 -2.526 86.42%
q17 105.84 122.53 16.682 115.76%
q18 217.17 163.25 -53.928 75.17%
q19 27.16 13.15 -14.009 48.43%
q20 40.56 25.17 -15.395 62.05%
q21 335.44 235.27 -100.172 70.14%
q22 17.06 15.49 -1.570 90.80%
total 1609.87 1282.32 -327.555 79.65%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants