Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Move validate methods from TransformerApi to ValidatorApi #3881

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[CORE] Move validate methods from TransformerApi to ValidatorApi #3881

merged 1 commit into from
Dec 1, 2023

Conversation

exmy
Copy link
Contributor

@exmy exmy commented Nov 29, 2023

What changes were proposed in this pull request?

How was this patch tested?

Pass CI

@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

zhztheplayer
zhztheplayer approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@exmy
Copy link
Contributor Author

exmy commented Dec 1, 2023

cc @PHILO-HE

PHILO-HE
PHILO-HE approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit d50a4a9 into apache:main Dec 1, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3881_time.csv log/native_master_11_30_2023_d2980b73a_time.csv difference percentage
q1 33.57 32.81 -0.758 97.74%
q2 26.49 26.03 -0.452 98.29%
q3 35.91 37.62 1.705 104.75%
q4 38.40 37.38 -1.022 97.34%
q5 71.61 72.32 0.712 100.99%
q6 7.41 6.56 -0.856 88.45%
q7 86.43 86.62 0.191 100.22%
q8 88.18 87.07 -1.112 98.74%
q9 127.87 126.83 -1.041 99.19%
q10 47.32 47.00 -0.315 99.33%
q11 20.53 20.00 -0.533 97.40%
q12 24.95 25.82 0.868 103.48%
q13 45.24 46.37 1.132 102.50%
q14 16.30 16.00 -0.294 98.20%
q15 29.06 27.70 -1.357 95.33%
q16 15.59 15.45 -0.134 99.14%
q17 103.38 102.12 -1.253 98.79%
q18 149.23 150.61 1.382 100.93%
q19 13.02 12.85 -0.169 98.70%
q20 29.80 27.48 -2.317 92.22%
q21 227.97 226.90 -1.073 99.53%
q22 13.28 13.04 -0.239 98.20%
total 1251.52 1244.58 -6.935 99.45%

kecookier added a commit to kecookier/gluten that referenced this pull request May 20, 2024
@kecookier
[CORE] Move validate methods from TransformerApi to ValidatorApi apac…
7dc8f5d 
…he#3881

[CORE] Move validate methods from TransformerApi to ValidatorApi apache#3881

* [CORE] Move validate methods from TransformerApi to ValidatorApi apache#3881

------

PR Link: https://dev.sankuai.com/code/repo-detail/data/gluten/pr/23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHILO-HE PHILO-HE PHILO-HE approved these changes

@zhztheplayer zhztheplayer zhztheplayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exmy @GlutenPerfBot @zhztheplayer @PHILO-HE