Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-1699][VL] Support loadLibFromJar on RedHat 7/8 #3893

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

ychris78
Copy link
Contributor

@ychris78 ychris78 commented Nov 30, 2023

What changes were proposed in this pull request?

It is mentioned in #1699 that using loadLibFromJar on RedHat 7/8 is not currently supported, The PR provides a fix correspondingly.

How was this patch tested?

manual tests

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@ychris78 ychris78 changed the title Support loadLibFromJar on RedHat 7/8 [GLUTEN-1699][VL] Support loadLibFromJar on RedHat 7/8 Nov 30, 2023
Copy link

#1699

@ychris78
Copy link
Contributor Author

ychris78 commented Dec 1, 2023

@zhouyuan could you help to review the code? Thanks

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CC @weiting-chen

@zhouyuan zhouyuan merged commit 26fc887 into apache:main Dec 1, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3893_time.csv log/native_master_11_30_2023_d2980b73a_time.csv difference percentage
q1 32.85 32.81 -0.033 99.90%
q2 24.80 26.03 1.229 104.95%
q3 36.24 37.62 1.378 103.80%
q4 37.65 37.38 -0.279 99.26%
q5 70.55 72.32 1.765 102.50%
q6 6.73 6.56 -0.167 97.51%
q7 83.71 86.62 2.912 103.48%
q8 87.15 87.07 -0.087 99.90%
q9 124.69 126.83 2.142 101.72%
q10 44.49 47.00 2.511 105.64%
q11 20.14 20.00 -0.141 99.30%
q12 26.46 25.82 -0.643 97.57%
q13 45.91 46.37 0.458 101.00%
q14 19.04 16.00 -3.035 84.06%
q15 28.94 27.70 -1.240 95.72%
q16 15.36 15.45 0.097 100.63%
q17 102.20 102.12 -0.074 99.93%
q18 151.74 150.61 -1.132 99.25%
q19 12.95 12.85 -0.093 99.28%
q20 27.58 27.48 -0.098 99.64%
q21 223.89 226.90 3.008 101.34%
q22 13.10 13.04 -0.057 99.57%
total 1236.16 1244.58 8.421 100.68%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_01_2023_time.csv log/native_master_11_30_2023_d2980b73a_time.csv difference percentage
q1 33.86 32.81 -1.046 96.91%
q2 25.15 26.03 0.881 103.50%
q3 38.03 37.62 -0.410 98.92%
q4 37.46 37.38 -0.089 99.76%
q5 72.27 72.32 0.053 100.07%
q6 7.31 6.56 -0.756 89.66%
q7 84.79 86.62 1.824 102.15%
q8 87.41 87.07 -0.345 99.61%
q9 123.56 126.83 3.269 102.65%
q10 43.60 47.00 3.403 107.81%
q11 20.18 20.00 -0.184 99.09%
q12 27.60 25.82 -1.781 93.55%
q13 46.11 46.37 0.261 100.57%
q14 14.72 16.00 1.287 108.74%
q15 29.45 27.70 -1.748 94.07%
q16 15.59 15.45 -0.140 99.10%
q17 102.69 102.12 -0.566 99.45%
q18 149.73 150.61 0.877 100.59%
q19 12.85 12.85 0.002 100.01%
q20 27.94 27.48 -0.458 98.36%
q21 225.25 226.90 1.642 100.73%
q22 13.32 13.04 -0.284 97.87%
total 1238.89 1244.58 5.690 100.46%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants