Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] gluten-te: Enable BuildKit to support --cache-from #3964

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Dec 7, 2023

The patch is a preparation of further CI docker script enhancements and should not impact current build procedure.

Ref of Docker external cache:

https://docs.docker.com/engine/reference/commandline/build/#cache-from

With the patch, we can perform the following in dedicated image-building job:

DOCKER_PUSH_REGISTRY=<registry> build.sh

Then we can use the cache to speed up build from another machine that have access to the registry:

DOCKER_CACHE_REGISTRY=<registry> build.sh

Copy link

github-actions bot commented Dec 7, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 7, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 8, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Dec 9, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhztheplayer zhztheplayer merged commit 22638f5 into apache:main Dec 11, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3964_time.csv log/native_master_12_10_2023_e9ea4e3e4_time.csv difference percentage
q1 33.50 34.68 1.181 103.52%
q2 24.66 27.19 2.533 110.27%
q3 38.67 37.58 -1.090 97.18%
q4 37.24 37.98 0.742 101.99%
q5 71.46 70.50 -0.959 98.66%
q6 7.11 6.93 -0.186 97.39%
q7 83.82 84.23 0.411 100.49%
q8 85.80 85.45 -0.351 99.59%
q9 126.08 126.22 0.142 100.11%
q10 43.57 43.28 -0.296 99.32%
q11 19.94 19.94 -0.000 100.00%
q12 27.50 27.48 -0.022 99.92%
q13 46.37 47.58 1.209 102.61%
q14 15.91 16.51 0.601 103.78%
q15 29.94 27.43 -2.510 91.62%
q16 16.42 15.68 -0.745 95.47%
q17 102.33 104.55 2.227 102.18%
q18 150.62 149.27 -1.357 99.10%
q19 14.28 13.60 -0.684 95.21%
q20 29.19 27.18 -2.013 93.10%
q21 221.96 225.87 3.907 101.76%
q22 13.45 13.10 -0.353 97.38%
total 1239.83 1242.22 2.388 100.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants