Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Following #3996, fix CI error "Runtime factory already registered" #4001

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

zhztheplayer
Copy link
Member

Fix a CI error introduced by #3996

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer
Copy link
Member Author

@rui-mo

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit 7d405d5 into apache:main Dec 12, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4001_time.csv log/native_master_12_11_2023_71ec720d4_time.csv difference percentage
q1 34.38 32.10 -2.279 93.37%
q2 24.82 24.79 -0.032 99.87%
q3 38.37 38.42 0.050 100.13%
q4 37.96 39.90 1.942 105.12%
q5 72.58 72.41 -0.173 99.76%
q6 6.72 7.02 0.300 104.47%
q7 87.25 85.38 -1.874 97.85%
q8 87.42 86.65 -0.774 99.11%
q9 127.24 126.76 -0.481 99.62%
q10 45.20 46.79 1.595 103.53%
q11 20.05 20.34 0.290 101.45%
q12 25.96 26.95 0.987 103.80%
q13 46.55 45.56 -0.988 97.88%
q14 14.50 18.31 3.805 126.24%
q15 27.88 27.78 -0.099 99.64%
q16 16.20 15.83 -0.374 97.69%
q17 102.58 101.57 -1.008 99.02%
q18 150.46 151.54 1.084 100.72%
q19 14.38 12.91 -1.477 89.73%
q20 28.09 26.84 -1.257 95.52%
q21 226.98 228.06 1.080 100.48%
q22 14.01 13.81 -0.196 98.60%
total 1249.59 1249.71 0.118 100.01%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants