[VL] Support inline function #4847
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
2 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
inline-function
branch
from
8f3d7bf to
66e822a
Compare
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
inline-function
branch
from
66e822a to
89d5740
Compare
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
inline-function
branch
from
89d5740 to
ecffd0c
Compare
|
Run Gluten Clickhouse CI |
marin-ma
changed the title
|
@zhouyuan Please kindly review. Thanks! |
| applyPostProjectOnGenerator(generateRel, context, operatorId, childOutput, validation) | ||
| } | ||
|
|
||
| private def applyPostProjectOnGenerator( |
There was a problem hiding this comment.
Could you please add one comment on when this should be called, any other cases than inline
There was a problem hiding this comment.
There are 3 types of CollectionGenerator in spark: Explode, PosExplode and Inline. Looks like only inline needs the post projection according Velox UnnestNode implementation. Besides, it would be better to implement this function in backends API. I will try PosExplode next and refine this part of code in another PR.
|
Run Gluten Clickhouse CI |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
As explode functions is already supported, we can also enable inline function by adding a post-project to get the inner fields from the struct.
As explode functions is already supported, we can also enable inline function by adding a post-project to get the inner fields from the struct.
As explode functions is already supported, we can also enable inline function by adding a post-project to get the inner fields from the struct.
As explode functions is already supported, we can also enable inline function by adding a post-project to get the inner fields from the struct.
As explode functions is already supported, we can also enable inline function by adding a post-project to get the inner fields from the struct.