Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup dev enviroment in mac os #819

Closed
wants to merge 1 commit into from
Closed

Conversation

CodingCat
Copy link
Contributor

What changes were proposed in this pull request?

This PR adds Dockerfile and docs about how to build dev environment in mac os

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

# Build Dev Environment in Mac OSX

This document describes how to set up a development environment in Mac OSX (for Velox backend). The development includes
both coding and runtime environment. For coding part, we follow the command practice to load
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common practice?

docker build -t gluten_dev:latest .
```

2. start a container. The following command start a container based on the image we
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*** will start a container ***

gluten project as a maven project in IntelliJ. For runtime part, as Gluten has not supported building and running
in Mac OSX, we leverage docker container here.

1. build docker image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion: please capitalize the initial letter, also for 2/3/4/5.

docker build -t gluten_dev:latest .
```

2. start a container. The following command start a container based on the image we
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion: it is better to split the titles and other content into different lines, also for 3/4/5.

ENV PATH=/spark-3.2.2-bin-hadoop3.2/bin:$PATH


RUN ln -fs /usr/share/zoneinfo/America/Los_Angeles /etc/localtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's user-location-specific command. Can it be removed or replaced by other command to adapt to different users?

@Yohahaha
Copy link
Contributor

have you try to build on macOS directly without Docker?

@CodingCat
Copy link
Contributor Author

CodingCat commented Jan 10, 2023 via email

@FelixYBW
Copy link
Contributor

Let's close this since it doesn't work

@FelixYBW FelixYBW closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants