[KOGITO-9785] Handle event state error #3270
Conversation
...w-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/handlers/StateHandler.java
Show resolved
Hide resolved
| CompositeContextNodeFactory<?> embeddedSubProcess = handleActions(makeCompositeNode(factory), onEvent.getActions()); | ||
| connect(result.getOutgoingNode(), embeddedSubProcess); | ||
| return new MakeNodeResult(result.getIncomingNode(), embeddedSubProcess); | ||
| if (isStartState) { |
There was a problem hiding this comment.
Start events uses a simplified approach, similar to the existing one.
Intermediate events now uses the split-join approach for timers.
Although the code is longer, one benefit is that now isStartState is checked only twice, when before was ubiquitous.
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3270 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3270/1/display/redirect Test results:
Those are the test failures: io.quarkus.it.kogito.process.HotReloadTest.testProcessJsonSchemajava.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.quarkus.workflows.PojoServiceIT.testPojoExpecting value to be true but was false |
...w-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/handlers/EventHandler.java
Show resolved
Hide resolved
fjtirado
force-pushed
the
KOGITO-9785a
branch
from
0b268b9 to
ea3148b
Compare
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3270 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3270/3/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojoExpecting value to be true but was false |
This reverts commit 3d83f1c.
fjtirado
force-pushed
the
KOGITO-9785a
branch
from
ea3148b to
94eccd9
Compare
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3270 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3270/6/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojoExpecting value to be true but was false |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3270 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3270/7/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojoExpecting value to be true but was false |
* [KOGITO-9785] Handle event state error * [KOGITO-9785] Walters comments * Revert "[KOGITO-9785] Walters comments" This reverts commit 3d83f1c.
Adding support for timedout errors for Event state.