[incubator-kie-issues-1108] Add capability to create node instances (node states) from the nodes #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node states) from the nodes
martinweiler
approved these changes
Apr 23, 2024
fjtirado
reviewed
Apr 24, 2024
| @Override | ||
| public List<NodeInstanceFactory> provide() { | ||
| List<NodeInstanceFactory> nodeInstanceFactoryList = new ArrayList<>(); | ||
| nodeInstanceFactoryList.add(new DefaultNodeInstanceFactory(RuleSetNode.class, RuleSetNodeInstance::new)); |
There was a problem hiding this comment.
@elguardian As we discussed as part of the proposal, I do not think RuleSetNodeInstance should be part of the default factory provider. That way DRL/DMN wont be a dependency of jbpm-flow.
Are we planning to do this split with a follow up Issue/PR? (probably better to do that as part of a follow up, just wondering if we are planning to do so or not)
There was a problem hiding this comment.
the scope of the PR is just adding the mechanism. @fjtirado
fjtirado
approved these changes
Apr 26, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
May 7, 2024
…node states) from the nodes (apache#3482)
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1108