[incubator-kie-issues-1136] Add script onEntry, on Exit for java #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3490 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3490/1/display/redirect Test results:
Those are the test failures: org.jbpm.ruleflow.core.validation.RuleFlowProcessValidatorTest.testOnEntryOnExitValidation[Extracted: message]Expecting ArrayList: ["Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] Milestone has no incoming connection.", "Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] Milestone has no outgoing connection."] to contain: ["Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] On Entry Action is not yet supported in Kogito", "Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] On Exit Action is not yet supported in Kogito"] but could not find the following element(s): ["Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] On Entry Action is not yet supported in Kogito", "Node 'name' [jbpm-26fb4859-a5bc-4244-b233-2817c2c68865] On Exit Action is not yet supported in Kogito"] org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[7][BoundaryEventNode] nodes with name [BoundaryEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[10][BoundaryEventNode] nodes with name [BoundaryEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[43][BoundaryEventNode] nodes with name [Boundary event] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[52][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[55][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[56][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[99][BoundaryEventNode] nodes with name [] are not equal |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3490 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3490/2/display/redirect Test results:
Those are the test failures: org.jbpm.ruleflow.core.validation.RuleFlowProcessValidatorTest.testOnEntryOnExitValidation[Extracted: message]Expecting ArrayList: ["Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] Milestone has no incoming connection.", "Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] Milestone has no outgoing connection."] to contain: ["Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] On Entry Action is not yet supported in Kogito", "Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] On Exit Action is not yet supported in Kogito"] but could not find the following element(s): ["Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] On Entry Action is not yet supported in Kogito", "Node 'name' [jbpm-197f923f-b67a-4c06-8810-88fb1dda9432] On Exit Action is not yet supported in Kogito"] org.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[7][BoundaryEventNode] nodes with name [BoundaryEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[10][BoundaryEventNode] nodes with name [BoundaryEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[43][BoundaryEventNode] nodes with name [Boundary event] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[52][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[55][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[56][BoundaryEventNode] nodes with name [TimerEvent] are not equalorg.kie.kogito.codegen.process.ProcessGenerationIT.testProcessGeneration(String)[99][BoundaryEventNode] nodes with name [] are not equal |
martinweiler
reviewed
May 1, 2024
jbpm/jbpm-flow-builder/src/main/java/org/jbpm/compiler/canonical/AbstractNodeVisitor.java
Outdated
Show resolved
Hide resolved
martinweiler
reviewed
May 1, 2024
jbpm/jbpm-flow/src/main/java/org/jbpm/ruleflow/core/factory/NodeFactory.java
Show resolved
Hide resolved
pefernan
requested changes
May 2, 2024
martinweiler
approved these changes
May 2, 2024
porcelli
requested changes
May 3, 2024
| private Expression buildDroolsConsequenceAction(ExtendedNodeImpl extendedNodeImpl, String dialect, String script) { | ||
| BlockStmt newDroolsConsequenceActionExpression = new BlockStmt(); | ||
| if (script != null) { | ||
| if (dialect.contains("java")) { |
There was a problem hiding this comment.
maybe add a log error message for not supported dialect
martinweiler
approved these changes
May 3, 2024
elguardian
force-pushed
the
incubator-kie-issues-1136
branch
from
cf44053 to
f8a984a
Compare
pefernan
approved these changes
May 6, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
May 7, 2024
…che#3490) * [incubator-kie-issues-1136] Add script onEntry, on Exit for java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1136