Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Adjust the position where Source calls addSourceReportInfo() #10102

Closed
2 tasks done
gosonzhang opened this issue Apr 29, 2024 · 0 comments · Fixed by #10103
Closed
2 tasks done

[Improve][DataProxy] Adjust the position where Source calls addSourceReportInfo() #10102

gosonzhang opened this issue Apr 29, 2024 · 0 comments · Fixed by #10103

Comments

@gosonzhang
Copy link
Contributor

Description

When each source is started, the IP, Port, processing logic, supported protocols and other information it uses will be collected through the addSourceReportInfo() function for Manager maintenance and processing:

  1. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/SimpleHttpSource.java#L104
  2. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/SimpleTcpSource.java#L113
  3. https://github.com/apache/inlong/blob/master/inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/source/SimpleUdpSource.java#L76

The current implementation places this operation in the subclass of each Source. In fact, it would be simpler to complete this operation directly in BaseSource.java

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant