You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the manager, I found some duplicated interfaces, e.g. InlongGroupService
/** * Save inlong group info. * * @param groupInfo group request need to save * @param operator name of operator * @return inlong group id after saving */Stringsave(@Valid@NotNull(message = "inlong group request cannot be null") InlongGroupRequestgroupInfo,
Stringoperator);
/** * Save inlong group info. * * @param groupInfo group request need to save * @param opInfo userinfo of operator * @return detail of inlong group */Stringsave(@Valid@NotNull(message = "inlong group request cannot be null") InlongGroupRequestgroupInfo,
UserInfoopInfo);
The only different is the second parameter, one is operator and the other is UserInfo, and the real usage of UserInfo is to get the operator by UserInfo#getName() .
So, this two methods are same essentially.
We can simplify the code here by unifying the two methods to one.
Description
In the manager, I found some duplicated interfaces, e.g.
InlongGroupService
The only different is the second parameter, one is
operator
and the other isUserInfo
, and the real usage ofUserInfo
is to get the operator byUserInfo#getName()
.So, this two methods are same essentially.
We can simplify the code here by unifying the two methods to one.
InLong Component
InLong Manager
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: