Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jansi support to version 2.x #1736

Closed
ppkarwasz opened this issue Aug 27, 2023 · 0 comments · Fixed by #3070
Closed

Upgrade Jansi support to version 2.x #1736

ppkarwasz opened this issue Aug 27, 2023 · 0 comments · Fixed by #3070
Labels
appenders Affects one or more Appender plugins dependencies Related to third party dependency updates or migrations enhancement Additions or updates to features

Comments

@ppkarwasz
Copy link
Contributor

Description

Although our POM file has an optional dependency on Jansi 2.4.0, the ConsoleAppender actually works only on Jansi 1.x.

We can modify ConsoleAppender to support both major versions of Jansi.
@ppkarwasz ppkarwasz added the enhancement Additions or updates to features label Aug 28, 2023
@jvz jvz added dependencies Related to third party dependency updates or migrations plugins Affects the plugin system appenders Affects one or more Appender plugins and removed plugins Affects the plugin system labels Oct 15, 2023
ppkarwasz added a commit that referenced this issue Sep 2, 2024
@ppkarwasz
Split and modernize JANSI support.
bf46e27 
This commit:

- Adds a new `ConsoleStreamProvider` plugin type that can decide how the Console Appender stream is built.
- Moves JAnsi support to a new `log4j-jansi` module.
- Upgrades the JAnsi library to version 2.x

Fixes #1736.
ppkarwasz added a commit that referenced this issue Sep 2, 2024
@ppkarwasz
Split and modernize JANSI support.
0e46fa9 
This commit:

- Adds a new `ConsoleStreamProvider` plugin type that can decide how the Console Appender stream is built.
- Moves JAnsi support to a new `log4j-jansi` module.
- Upgrades the JAnsi library to version 2.x

Fixes #1736.
ppkarwasz added a commit that referenced this issue Sep 2, 2024
@ppkarwasz
Split and modernize JANSI support.
d0d22f8 
This commit:

- Adds a new `ConsoleStreamProvider` plugin type that can decide how the Console Appender stream is built.
- Moves JAnsi support to a new `log4j-jansi` module.
- Upgrades the JAnsi library to version 2.x

Fixes #1736.
ppkarwasz added a commit that referenced this issue Sep 2, 2024
@ppkarwasz
Split and modernize JANSI support.
982e0bc 
This commit:

- Adds a new `ConsoleStreamProvider` plugin type that can decide how the Console Appender stream is built.
- Moves JAnsi support to a new `log4j-jansi` module.
- Upgrades the JAnsi library to version 2.x

Fixes #1736.
@ppkarwasz ppkarwasz mentioned this issue Sep 2, 2024
Merged
ppkarwasz added a commit that referenced this issue Oct 7, 2024
@ppkarwasz
Remove JANSI dependency (#2916)
713ec50 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes #1736.
ppkarwasz added a commit that referenced this issue Oct 8, 2024
@ppkarwasz
Remove JANSI dependency in 2.x
26d0997 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes #1736.
ppkarwasz added a commit that referenced this issue Oct 8, 2024
@ppkarwasz
Remove JANSI dependency in 2.x
2ea1e93 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes #1736.
@ppkarwasz ppkarwasz mentioned this issue Oct 8, 2024
Merged
ppkarwasz added a commit that referenced this issue Oct 16, 2024
@ppkarwasz
Remove JANSI dependency in 2.x (#3070)
f345ded 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes #1736.
hulkoba pushed a commit to neighbourhoodie/logging-log4j2 that referenced this issue Oct 21, 2024
@ppkarwasz @hulkoba
Remove JANSI dependency in 2.x (apache#3070)
dd8f579 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes apache#1736.
hulkoba pushed a commit to neighbourhoodie/logging-log4j2 that referenced this issue Oct 21, 2024
@ppkarwasz @hulkoba
Remove JANSI dependency in 2.x (apache#3070)
f43e9b2 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes apache#1736.
vy pushed a commit that referenced this issue Oct 25, 2024
@ppkarwasz @vy
Remove JANSI dependency in 2.x (#3070)
9ef736f 
This commit:

- Removes support for the outdated [Jansi 1.x](http://fusesource.github.io/jansi/) version in `Console` appender.
- Rewrites `JAnsiTextRenderer`, use in the `%m{ansi}` and `%ex{ansi}` pattern converters to use our internal ANSI support instead of Jansi.

Fixes #1736.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appenders Affects one or more Appender plugins dependencies Related to third party dependency updates or migrations enhancement Additions or updates to features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove JANSI dependency in 2.x apache/logging-log4j2
2 participants
@jvz @ppkarwasz