Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MongoDB appender against Docker image #2229

Open
ppkarwasz opened this issue Jan 23, 2024 · 2 comments
Open

Test MongoDB appender against Docker image #2229

ppkarwasz opened this issue Jan 23, 2024 · 2 comments
Labels
appenders:MongoDB Issue related to the MongoDB appender

Comments

@ppkarwasz
Copy link
Contributor

Right now (after #1589), we are using Embedded MongoDB to:

  • download a MongoDB distribution on our system,
  • run it with the correct parameters,
  • test the MongoDB appender.

This procedure has some problems:

  1. we cannot run tests in parallel on a clean system (each test tries to download MongoDB at the same time),
  2. the MongoDB distribution depends on some system libraries that are not always present.

Therefore we should move the tests to use TestContainers or an equivalent solution and the official Docker mongo images.

@ppkarwasz ppkarwasz added the appenders:MongoDB Issue related to the MongoDB appender label Jan 23, 2024
@ppkarwasz
Copy link
Contributor Author

@garydgregory, could you look into this?

@vy
Copy link
Member

vy commented Jan 23, 2024

@garydgregory, @ppkarwasz, I would prefer a uniform container-based testing across the code base. log4j-layout-template-json-test uses docker-maven-plugin behind a docker profile. I am in favor of adapting this to log4j-mongodb* modules.

If we will be going to Testontainers route, which is fine, I would appreciate it if we can migrate log4j-layout-template-json-test there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appenders:MongoDB Issue related to the MongoDB appender
Projects
None yet
Development

No branches or pull requests

2 participants