Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move o.a.l.l.core.parser to samples #2154

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

ppkarwasz
Copy link
Contributor

We move o.a.l.l.core.parser to the samples repository, since it is independent from Log4j Core and unused:

apache/logging-log4j-samples@de33cee

This code is potentially (transitively) exploitable each time Jackson has a deserialization vulnerability.

Part of #2016.

@ppkarwasz
Copy link
Contributor Author

@mikaelstaldal, do you agree with this refactoring or did you plan to use the event parser in log4j-core?

@mikaelstaldal
Copy link
Contributor

Oh, I have not been active in this project for a long time, so I don't have any objections.

We move `o.a.l.l.core.parser` to the samples repository, since it is
independent from Log4j Core and unused:

apache/logging-log4j-samples@de33cee

This code is potentially (transitively) exploitable each time Jackson
has a deserialization vulnerability.

Part of apache#2016.
@ppkarwasz ppkarwasz self-assigned this Jan 3, 2024
@ppkarwasz ppkarwasz merged commit f52b69f into apache:main Jan 3, 2024
7 checks passed
ppkarwasz added a commit that referenced this pull request Jan 3, 2024
@ppkarwasz ppkarwasz deleted the remove-parser branch January 3, 2024 13:45
@ppkarwasz
Copy link
Contributor Author

@sanova,

Do you need us to move o.a.l.l.core.parser to a new module instead of removing it?

@vy vy added this to the 3.0.0 milestone Jan 5, 2024
@vy vy self-requested a review January 5, 2024 13:39
Copy link
Member

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally support this removal and the changes LGTM.

@ppkarwasz ppkarwasz modified the milestones: 3.0.0, 3.0.0-beta2 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants