Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j-iostreams from main #2630

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

ppkarwasz
Copy link
Contributor

The Log4j IOStreams module is part of the Log4j API library. Since Log4j API 3 will not be release, Log4j IOStreams 3 shouldn't be released either.

@rgoers
Copy link
Member

rgoers commented May 30, 2024

I have never considered log4j-iostreams to be part of Log4j-API. That said, it only has test dependencies on log4j-core and does not have any plugins so I see no reason why we need a 3.x specific version of this.

@rgoers rgoers self-assigned this May 30, 2024
@ppkarwasz ppkarwasz force-pushed the feature/main/remove-iostreams branch from b63d5c4 to 0e39648 Compare June 5, 2024 05:12
The Log4j IOStreams module is part of the Log4j API library.
Since Log4j API 3 will not be release, Log4j IOStreams 3 shouldn't be
released either.
@ppkarwasz ppkarwasz force-pushed the feature/main/remove-iostreams branch from 0e39648 to e3fabea Compare June 19, 2024 12:16
@ppkarwasz ppkarwasz merged commit e3fabea into main Jun 19, 2024
6 checks passed
@ppkarwasz ppkarwasz deleted the feature/main/remove-iostreams branch June 19, 2024 12:17
@garydgregory
Copy link
Member

This is so confusing to me. So we are keeping 2.x for the API and main which is 3.x alive in parallel forever? Do we document this somewhere?

@ppkarwasz
Copy link
Contributor Author

This is so confusing to me. So we are keeping 2.x for the API and main which is 3.x alive in parallel forever? Do we document this somewhere?

It is documented on the 3.x staging site.

@rgoers
Copy link
Member

rgoers commented Jun 19, 2024

@garydgregory This is why it would be less confusing if Log4j API and components only dependent on Log4j API (i.e. not dependent on log4j-core) were moved to a different repo.

@garydgregory
Copy link
Member

So eventually, once 3.x is out, how do I use the iostreams code?

@ppkarwasz
Copy link
Contributor Author

So eventually, once 3.x is out, how do I use the iostreams code?

Nothing changes: log4j-iostreams only depends on log4j-api (same as all the bridges X-to-Log4j API).
Since log4j-bom version 3.x has been updated to contain the appropriate version of log4j-iostreams, you don't even need to know that the version number your are using is 2.x.

@garydgregory
Copy link
Member

Phew! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants