Move ConversantMedia disruptor blocking queue to new module #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vy
reviewed
Sep 4, 2024
...sant/src/main/java/org/apache/logging/log4j/conversant/DisruptorRecyclerFactoryProvider.java
Outdated
Show resolved
Hide resolved
vy
added
performance
vy
requested changes
Sep 6, 2024
log4j-conversant/src/main/java/org/apache/logging/log4j/conversant/DisruptorProperties.java
Outdated
Show resolved
Hide resolved
vy
reviewed
Sep 6, 2024
log4j-kit/src/main/java/org/apache/logging/log4j/kit/recycler/internal/CapacityUtil.java
Show resolved
Hide resolved
Moves `DisruptorBlockingQueue` to a separate module. Includes peer review (cf. #2914).
ppkarwasz
force-pushed
the
feature/main/move-conversant
branch
from
d76181e to
f25c5e4
Compare
ppkarwasz
added a commit
that referenced
this pull request
Sep 12, 2024
Moves `DisruptorBlockingQueue` to a separate module. Includes peer review (cf. #2914).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
DisruptorBlockingQueueplugin to a newlog4j-conversantmodule.This change is necessary to remove an optional dependency from
log4j-core.