Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move anonymous Weight implementation in PointRangeQuery to named class #13710

Open
jainankitk opened this issue Sep 3, 2024 · 0 comments
Open

Move anonymous Weight implementation in PointRangeQuery to named class #13710

jainankitk opened this issue Sep 3, 2024 · 0 comments
Labels
type:task

Comments

@jainankitk
Copy link
Contributor

Description

The Weight implementation in PointRangeQuery#createWeight is anonymous class making it difficult to extend or reuse specific logic from the class. Not to mention the class being more ~400 lines of code which makes good case for named class anyways IMO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jainankitk