Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ULP float comparison instead of epsilon-based comparison #13789

Open
stefanvodita opened this issue Sep 14, 2024 · 0 comments
Open

Use ULP float comparison instead of epsilon-based comparison #13789

stefanvodita opened this issue Sep 14, 2024 · 0 comments

Comments

@stefanvodita
Copy link
Contributor

Description

#13723 introduced new methods for testing floating point equality based on number of units-of-least-precision rather than a fixed error. We should check which tests would benefit form using it. One candidate are the Panama vs scalar vector tests. The tricky bit will be to figure out the correct number of ULPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant