Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted files being added to projects #343

Closed
nazjunaid opened this issue Sep 20, 2020 · 4 comments
Closed

Unwanted files being added to projects #343

nazjunaid opened this issue Sep 20, 2020 · 4 comments
Assignees
@NightOwl888
Labels
is:bug

Comments

@nazjunaid
Copy link
Contributor

Adding Lucene.Net via nuget is adding some unwanted files to our projects namely.

j2n-icon-100x100.png
LICENSE.txt

There there a reason why it needs to do this?
@TheBeardedLlama
Copy link

probably mistake in the packaging of the most recent release

should be easy to resolve with a quick PR

@nazjunaid
Copy link
Contributor Author

Just had a dig around looks like it's coming from J2N

https://github.com/NightOwl888/J2N/blob/ee502ac09b9ea6b84ff36c2778665991cfe612ac/build/nuget.props

@TheBeardedLlama
Copy link

ah yeah

considering they're in beta, they could easily do a new release removing those I guess

@NightOwl888 NightOwl888 self-assigned this Sep 21, 2020
@NightOwl888
Copy link
Contributor

This has now been addressed in

To target Lucene.Net 4.8.0-beta00012 or lower, you will need to install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NightOwl888 NightOwl888

Labels
is:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nazjunaid @TheBeardedLlama @NightOwl888