From 74d331be89ed010b5d38dc6e755dcab327baf56c Mon Sep 17 00:00:00 2001
From: Tamas Cservenak <tamas@cservenak.net>
Date: Wed, 24 Apr 2024 16:11:46 +0200
Subject: [PATCH] [MDEPLOY-316] Parent 42 and prerequisite 3.6.3 (#54)

Update parent to 42 and prerequisite to Maven 3.6.3

---

https://issues.apache.org/jira/browse/MDEPLOY-316
---
 .github/workflows/maven-verify.yml                            | 2 ++
 pom.xml                                                       | 4 ++--
 .../org/apache/maven/plugins/deploy/AbstractDeployMojo.java   | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml
index 932827cf..681f3d34 100644
--- a/.github/workflows/maven-verify.yml
+++ b/.github/workflows/maven-verify.yml
@@ -25,3 +25,5 @@ jobs:
   build:
     name: Verify
     uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v4
+    with:
+      jdk-distribution-matrix: '[ "zulu" ]'
diff --git a/pom.xml b/pom.xml
index f8422a88..92c4bc03 100644
--- a/pom.xml
+++ b/pom.xml
@@ -23,7 +23,7 @@ under the License.
   <parent>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-plugins</artifactId>
-    <version>41</version>
+    <version>42</version>
     <relativePath />
   </parent>
 
@@ -43,7 +43,7 @@ under the License.
   </contributors>
 
   <prerequisites>
-    <maven>3.2.5</maven>
+    <maven>3.6.3</maven>
   </prerequisites>
 
   <scm>
diff --git a/src/main/java/org/apache/maven/plugins/deploy/AbstractDeployMojo.java b/src/main/java/org/apache/maven/plugins/deploy/AbstractDeployMojo.java
index 2c5c1d9c..d8da6922 100644
--- a/src/main/java/org/apache/maven/plugins/deploy/AbstractDeployMojo.java
+++ b/src/main/java/org/apache/maven/plugins/deploy/AbstractDeployMojo.java
@@ -99,6 +99,7 @@ protected void warnIfAffectedPackagingAndMaven(final String packaging) {
      * Creates resolver {@link RemoteRepository} equipped with needed whistles and bells.
      */
     protected RemoteRepository getRemoteRepository(final String repositoryId, final String url) {
+        // TODO: RepositorySystem#newDeploymentRepository does this very same thing!
         RemoteRepository result = new RemoteRepository.Builder(repositoryId, "default", url).build();
 
         if (result.getAuthentication() == null || result.getProxy() == null) {