Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

mxnet-full jar depends on mxnet-core and mxnet-infer jars while containing all their classes #15634

Open
vkorenev opened this issue Jul 23, 2019 · 5 comments

Comments

@vkorenev
Copy link

The current Maven build for Scala produces mxnet-full_2.11 package which pulls mxnet-core and mxnet-infer packages by dependency. However mxnet-full jar already contains all the classes from those 2 jars, so there is no need to include them again.

MXNet commit hash: 77254f2a829d481d61e015e900923f1edb4af39f.

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Feature

@keerthanvasist
Copy link

@mxnet-label-bot add [scala, build]

@zachgk
Copy link
Contributor

zachgk commented Jul 23, 2019

@vkorenev Are you looking at the versioned mxnet-full or the INTERNAL one? When you build the assembly module, it flattens and includes the code from the other modules. Once they are flattened, we deploy it and use https://github.com/apache/incubator-mxnet/blob/master/scala-package/deploy/pom.xml as the pom.xml instead of the one inherited from the assembly plugin. You can view the deployed version by running mvn deploy and then looking in your deploy/target/repo folder

@vkorenev
Copy link
Author

Then mvn install should replace the pom before installing mxnet-full to the local repo.

@zachgk
Copy link
Contributor

zachgk commented Jul 24, 2019

We currently use the deploy plugin to replace the pom file so this isn't a tiny change. We also have fewer details such as no hardware (CPU/GPU) when you use the install version which many of our scripts depend on.

You could try using mvn deploy -Drepo_url=file://$HOME/.m2/repository and that would give you a full release with the replaced POM and version 1.5.0-SNAPSHOT.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants