Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Flaky Test] test_operator_gpu.test_ftrl #18003

Closed
zixuanweeei opened this issue Apr 9, 2020 · 6 comments · Fixed by #18226
Closed

[Flaky Test] test_operator_gpu.test_ftrl #18003

zixuanweeei opened this issue Apr 9, 2020 · 6 comments · Fixed by #18226

Comments

@zixuanweeei
Copy link
Contributor Author

@mxnet-label-bot add [gpu, optimizer]

@ptrendx
Copy link
Member

ptrendx commented Apr 9, 2020

Also seen in #17995.

@ptrendx
Copy link
Member

ptrendx commented Apr 9, 2020

Hmm, something is wrong with the random seed generation of tests - all those failing test_ftrl got the same seed:

common: INFO: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=386103813 to reproduce.

FYI @roywei Since you are already looking at random-related stuff and @DickJC123 since you wrote the @with_seed facility.

@leezu
Copy link
Contributor

leezu commented Apr 10, 2020

@szha plans to switch the testing suite to pytest
This involves refactoring the randomness logic and may fix the issue. The new code would likely be inspired by the code in GluonNLP, where we transitioned to pytest already in the initial release and thus refactored the random-related stuff for pytest.

https://github.com/dmlc/gluon-nlp/blob/v0.9.x/conftest.py#L41

@leezu
Copy link
Contributor

leezu commented Apr 23, 2020

As a sanity check for the pytest random seed infrastructure: Test failure can be reproduced deterministically using:

MXNET_TEST_SEED=1632189249 pytest tests/python/unittest/test_optimizer.py -k test_ftrl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants