From a7473b0fae644592fe621d3a859e7384893ec3ba Mon Sep 17 00:00:00 2001 From: Piyush Ghai Date: Wed, 24 Oct 2018 12:54:55 -0700 Subject: [PATCH] Bumping down minimum java support from 8 to 7 --- .../apache/mxnet/javaapi/ResourceScopeTestSuite.java | 12 +++++++++--- scala-package/pom.xml | 4 ++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java b/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java index f570ba927faa..1c246d870e28 100644 --- a/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java +++ b/scala-package/core/src/test/java/org/apache/mxnet/javaapi/ResourceScopeTestSuite.java @@ -73,7 +73,9 @@ public void testObjectReleaseFromList() { } assertEquals(list.size() , 10); - list.forEach(n -> assertTrue(n.verifyIsDisposed())); + for (TestNDArray item : list) { + assertTrue(item.verifyIsDisposed()); + } } @Test @@ -87,7 +89,9 @@ public void testObjectReleaseFromMap() { } assertEquals(stringToNDArrayMap.size(), 10); - stringToNDArrayMap.forEach((key, value) -> assertTrue(value.verifyIsDisposed())); + for (Map.Entry entry : stringToNDArrayMap.entrySet()) { + assertTrue(entry.getValue().verifyIsDisposed()); + } Map ndArrayToStringMap = new HashMap<>(); @@ -98,7 +102,9 @@ public void testObjectReleaseFromMap() { } assertEquals(ndArrayToStringMap.size(), 10); - ndArrayToStringMap.forEach((key, value) -> assertTrue(key.verifyIsDisposed())); + for (Map.Entry entry : ndArrayToStringMap.entrySet()) { + assertTrue(entry.getKey().verifyIsDisposed()); + } } } diff --git a/scala-package/pom.xml b/scala-package/pom.xml index eb3f6f0b3354..9f7a498ee9b5 100644 --- a/scala-package/pom.xml +++ b/scala-package/pom.xml @@ -190,8 +190,8 @@ maven-compiler-plugin 3.3 - 1.8 - 1.8 + 1.7 + 1.7 UTF-8