From 5f0ae511073442861a8da4acdbc3136771865b3e Mon Sep 17 00:00:00 2001 From: barry-jin Date: Tue, 6 Jul 2021 18:35:42 -0700 Subject: [PATCH 1/4] fix precision --- src/operator/tensor/elemwise_binary_scalar_op.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operator/tensor/elemwise_binary_scalar_op.h b/src/operator/tensor/elemwise_binary_scalar_op.h index a6fdf1e7572d..f87f2282f9c3 100644 --- a/src/operator/tensor/elemwise_binary_scalar_op.h +++ b/src/operator/tensor/elemwise_binary_scalar_op.h @@ -50,7 +50,7 @@ struct NumpyBinaryScalarParam : public dmlc::Parameter { void SetAttrDict(std::unordered_map* dict) { std::ostringstream scalar_s, is_int_s; - scalar_s << scalar; + scalar_s << std::setprecision(15) << scalar; is_int_s << is_int; (*dict)["scalar"] = scalar_s.str(); (*dict)["is_int"] = is_int_s.str(); From 6ee73389cf74e918e4b1f69e0a542cc0201c64d8 Mon Sep 17 00:00:00 2001 From: barry-jin Date: Tue, 6 Jul 2021 19:03:28 -0700 Subject: [PATCH 2/4] fix --- src/operator/tensor/elemwise_binary_scalar_op.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/operator/tensor/elemwise_binary_scalar_op.h b/src/operator/tensor/elemwise_binary_scalar_op.h index f87f2282f9c3..ea7bc440427c 100644 --- a/src/operator/tensor/elemwise_binary_scalar_op.h +++ b/src/operator/tensor/elemwise_binary_scalar_op.h @@ -50,7 +50,7 @@ struct NumpyBinaryScalarParam : public dmlc::Parameter { void SetAttrDict(std::unordered_map* dict) { std::ostringstream scalar_s, is_int_s; - scalar_s << std::setprecision(15) << scalar; + scalar_s << std::setprecision(std::numeric_limits::max_digits10) << scalar; is_int_s << is_int; (*dict)["scalar"] = scalar_s.str(); (*dict)["is_int"] = is_int_s.str(); From 4b6c1ee988f9272a4811cccf93a62d0ed88b13fa Mon Sep 17 00:00:00 2001 From: barry-jin Date: Tue, 6 Jul 2021 19:13:50 -0700 Subject: [PATCH 3/4] fix --- src/operator/tensor/elemwise_binary_scalar_op.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/operator/tensor/elemwise_binary_scalar_op.h b/src/operator/tensor/elemwise_binary_scalar_op.h index ea7bc440427c..13d147bc698c 100644 --- a/src/operator/tensor/elemwise_binary_scalar_op.h +++ b/src/operator/tensor/elemwise_binary_scalar_op.h @@ -26,6 +26,7 @@ #define MXNET_OPERATOR_TENSOR_ELEMWISE_BINARY_SCALAR_OP_H_ #include +#include #include #include #include From 1556043c11d802d82a0ff0a248f30aabbb78cc7b Mon Sep 17 00:00:00 2001 From: barry-jin Date: Tue, 6 Jul 2021 20:44:24 -0700 Subject: [PATCH 4/4] fix --- tests/python/unittest/test_numpy_op.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/python/unittest/test_numpy_op.py b/tests/python/unittest/test_numpy_op.py index 1abbeba4fcf2..053fa9d64daa 100644 --- a/tests/python/unittest/test_numpy_op.py +++ b/tests/python/unittest/test_numpy_op.py @@ -3458,9 +3458,9 @@ def forward(self, a): @use_np def test_npx_activation_log_sigmoid(): def np_log_sigmoid(x): - return _np.log(_np.divide(1.0, (1.0 + _np.exp(-x)))) + return onp.log(onp.divide(1.0, (1.0 + onp.exp(-x)))) def np_log_sigmoid_grad(x): - return _np.divide(1.0, _np.add(1.0, _np.exp(x))) + return onp.divide(1.0, onp.add(1.0, onp.exp(x))) class TestLogSigmoid(HybridBlock): def __init__(self):