Ensure left search results panel is always visible. #8088
Merged
+41
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Editor
Platform
matthiasblaesing
approved these changes
Dec 25, 2024
Good catch - I'll take a look. Oh boy, I really hate copy pasted code. Will try to deduplicate this a bit if possible. |
initialize divider position with a minimal value.
- BasicReplaceResultsPanel extends BasicSearchResultsPanel - less code duplication
mbien
force-pushed
the
fix-search-result-divider
branch
from
fc77252 to
6635544
Compare
|
@matthiasblaesing added the change to the first commit. The second commit refactors the two panels ( |
matthiasblaesing
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize divider position with a minimal value. This will always reset the value to at least 250 even if it is changed by the user to less.
fixes #8064
I could reproduce this sometimes with
I believe what happens in this case is that the divider isn't initialized (which is fine by itself) but the computed width of the left panel is 0 for some reason too (which is not ok).