From 43d4c85a96c0e8fd71f6a2ade9981b0f08404f2b Mon Sep 17 00:00:00 2001
From: Trim21 <trim21.me@gmail.com>
Date: Tue, 24 Dec 2024 04:54:10 +0800
Subject: [PATCH] disable windows free thread build

---
 .github/workflows/release_python.yml | 3 +++
 bindings/python/Cargo.toml           | 8 +++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/release_python.yml b/.github/workflows/release_python.yml
index 2d98647fdfe2..99ea4b858754 100644
--- a/.github/workflows/release_python.yml
+++ b/.github/workflows/release_python.yml
@@ -85,6 +85,9 @@ jobs:
           sccache: true
           manylinux: auto
       - name: Build free-threaded wheels
+        # windows free-threading building doesn't work on windows
+        # https://github.com/apache/opendal/pull/5449#issuecomment-2560469190
+        if: ${{ runner.os != 'Windows' }}
         uses: PyO3/maturin-action@v1
         with:
           working-directory: "bindings/python"
diff --git a/bindings/python/Cargo.toml b/bindings/python/Cargo.toml
index a2db6361c85d..87f6df2b8e37 100644
--- a/bindings/python/Cargo.toml
+++ b/bindings/python/Cargo.toml
@@ -150,7 +150,7 @@ services-upyun = ["opendal/services-upyun"]
 services-vercel-artifacts = ["opendal/services-vercel-artifacts"]
 services-yandex-disk = ["opendal/services-yandex-disk"]
 # we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop cp310
-abi3 = ["pyo3/abi3-py311"]
+abi3 = ["pyo3/abi3-py311", "pyo3/generate-import-lib"]
 
 [lib]
 crate-type = ["cdylib"]
@@ -160,10 +160,8 @@ doc = false
 bytes = "1.5.0"
 futures = "0.3.28"
 # this crate won't be published, we always use the local version
-opendal = { version = ">=0", path = "../../core", features = [
-  "layers-blocking",
-] }
-pyo3 = { version = "0.23.3", features = ["generate-import-lib"] }
+opendal = { version = ">=0", path = "../../core", features = ["layers-blocking"] }
+pyo3 = { version = "0.23.3", features = ["extension-module"] }
 pyo3-async-runtimes = { version = "0.23.0", features = ["tokio-runtime"] }
 tokio = "1"