diff --git a/.github/workflows/ci_integration_object_store.yml b/.github/workflows/ci_integration_object_store.yml index 824186aef1de..bedd48aa3e99 100644 --- a/.github/workflows/ci_integration_object_store.yml +++ b/.github/workflows/ci_integration_object_store.yml @@ -45,3 +45,7 @@ jobs: - name: Cargo clippy working-directory: integrations/object_store run: cargo clippy --all-targets --all-features -- -D warnings + + - name: Cargo test + working-directory: integrations/object_store + run: cargo test diff --git a/integrations/object_store/src/lib.rs b/integrations/object_store/src/lib.rs index 37b46d171bb2..2afe685eb89e 100644 --- a/integrations/object_store/src/lib.rs +++ b/integrations/object_store/src/lib.rs @@ -31,16 +31,11 @@ //! //! #[tokio::main] //! async fn main() { -//! let builder = S3::from_map( -//! vec![ -//! ("access_key".to_string(), "my_access_key".to_string()), -//! ("secret_key".to_string(), "my_secret_key".to_string()), -//! ("endpoint".to_string(), "my_endpoint".to_string()), -//! ("region".to_string(), "my_region".to_string()), -//! ] -//! .into_iter() -//! .collect(), -//! ).unwrap(); +//! let builder = S3::default() +//! .access_key_id("my_access_key") +//! .secret_access_key("my_secret_key") +//! .endpoint("my_endpoint") +//! .region("my_region"); //! //! // Create a new operator //! let operator = Operator::new(builder).unwrap().finish(); diff --git a/integrations/object_store/src/store.rs b/integrations/object_store/src/store.rs index d7dc8193a108..1339f1bb78fe 100644 --- a/integrations/object_store/src/store.rs +++ b/integrations/object_store/src/store.rs @@ -62,16 +62,11 @@ use tokio::sync::{Mutex, Notify}; /// /// #[tokio::main] /// async fn main() { -/// let builder = S3::from_map( -/// vec![ -/// ("access_key".to_string(), "my_access_key".to_string()), -/// ("secret_key".to_string(), "my_secret_key".to_string()), -/// ("endpoint".to_string(), "my_endpoint".to_string()), -/// ("region".to_string(), "my_region".to_string()), -/// ] -/// .into_iter() -/// .collect(), -/// ).unwrap(); +/// let builder = S3::default() +/// .access_key_id("my_access_key") +/// .secret_access_key("my_secret_key") +/// .endpoint("my_endpoint") +/// .region("my_region"); /// /// // Create a new operator /// let operator = Operator::new(builder).unwrap().finish();