Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM Support #253

Closed
Xuanwo opened this issue Apr 24, 2022 · 4 comments · Fixed by #3796
Closed

WASM Support #253

Xuanwo opened this issue Apr 24, 2022 · 4 comments · Fixed by #3796

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 24, 2022

We need to wait for some key deps to support wasm:

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 28, 2022

tokio-rs/tokio#4716 has been closed. We can try to find out how blocks are in front of us.

@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Sep 15, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 19, 2023

We can allow accessing s3/gcs from browser

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 20, 2023

Some blocks:

note: future is not `Send` as this value is used across an await
    --> /home/xuanwo/.cargo/registry/src/gh.neting.cc-1ecc6299db9ec823/reqwest-0.11.14/src/wasm/client.rs:225:57
     |
185  |       let mut init = web_sys::RequestInit::new();
     |           -------- has type `web_sys::features::gen_RequestInit::RequestInit` which is not `Send`
...
225  |       let js_resp = super::promise::<web_sys::Response>(p)
     |  _________________________________________________________^
226  | |         .await
     | |______________^ await occurs here, with `mut init` maybe used later
...
252  |   }
     |   - `mut init` is later dropped here
     = note: required for the cast from `impl futures::Future<Output = std::result::Result<rps::RpCompleteMultipart, error::Error>>` to the object type `dyn futures::Future<Output = std::result::Result<rps::RpCompleteMultipart, error::Error>> + std::marker::Send`

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 21, 2023

We can use https://docs.rs/tokio/latest/tokio/task/struct.LocalSet.html for JsFuture

@Xuanwo Xuanwo self-assigned this Oct 10, 2023
@Xuanwo Xuanwo removed their assignment Nov 9, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 📦 Done in Databend Storage Layer Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant