-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdrive] potential regression of folder name handling #4722
Comments
this regression is happening between v0.45.1 and v0.46.0 this is the last correct version: https://github.com/apache/opendal/blob/v0.45.1/core/src/services/gdrive/core.rs#L396 |
opendal/core/src/services/gdrive/core.rs Lines 396 to 405 in 27c6a77
Maybe we should trim the |
let me try! |
it seems to be fixed by this change. ![]() https://github.com/imWildCat/opendal/commits/main/ I also found another issue shown above: opendal now create folder with same names... |
We should already have checks for the folder exist before creating. Maybe some logic not adapated yet? Like creating |
Could it be related to cache? |
The cache is thread-safe, so concurrent calls should not pose a problem. I believe this issue is related to how we handle paths. |
after the fix you proposed above, the duplication problem still exists. |
anyway, let me create a PR to fix the naming issue first. |
Hi, I've been quite busy recently. I plan to set aside some time next week to debug this issue. |
Thanks! |
in my app, I found folders would have extra
/
for google drivemight be a regression recently
The text was updated successfully, but these errors were encountered: