-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swagger schema hardocded and references ibm properties #87
Comments
Why? this limits are applicable and valid to open source gateway |
They are not ibm specific |
The fields are hard coded and called “x-ibm-...“ as in:
|
Yeah for backwards compatibility the it can x-ibm or “x- something else” don’t remember right now what’s the other option for the same |
Both work in the api gateway |
There are no references to XConfig or XRateLimit in the project - how about we remove them... actually I'd remove the entire class, I don't think these types help much anyway and just over constrain the schema ---- or as shown several times, they get out of sync. |
See ongoing discussion here: #88 |
This schema should not include IBM specific properties:
See https://github.com/apache/incubator-openwhisk-client-go/blob/1759868a61729708a8ab1a6de1b409d6e2aea00a/whisk/api.go#L153-L154
I think the entire struct should be removed anyway - it overly restricts the schema unnecessarily.
The text was updated successfully, but these errors were encountered: