Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger schema hardocded and references ibm properties #87

Open
rabbah opened this issue May 20, 2018 · 7 comments
Open

swagger schema hardocded and references ibm properties #87

rabbah opened this issue May 20, 2018 · 7 comments
Labels

Comments

@rabbah
Copy link
Member

rabbah commented May 20, 2018

This schema should not include IBM specific properties:

See https://github.com/apache/incubator-openwhisk-client-go/blob/1759868a61729708a8ab1a6de1b409d6e2aea00a/whisk/api.go#L153-L154

I think the entire struct should be removed anyway - it overly restricts the schema unnecessarily.

@rabbah rabbah added the bug label May 20, 2018
@csantanapr
Copy link
Member

Why? this limits are applicable and valid to open source gateway

@csantanapr
Copy link
Member

They are not ibm specific

@rabbah
Copy link
Member Author

rabbah commented May 20, 2018

The fields are hard coded and called “x-ibm-...“ as in:

x-ibm-configuration
x-ibm-rate-limit

@csantanapr
Copy link
Member

Yeah for backwards compatibility the it can x-ibm or “x- something else” don’t remember right now what’s the other option for the same

@csantanapr
Copy link
Member

Both work in the api gateway

@rabbah
Copy link
Member Author

rabbah commented May 21, 2018

There are no references to XConfig or XRateLimit in the project - how about we remove them... actually I'd remove the entire class, I don't think these types help much anyway and just over constrain the schema ---- or as shown several times, they get out of sync.

@rabbah
Copy link
Member Author

rabbah commented May 21, 2018

See ongoing discussion here: #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants