Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Index Config settings not preserved when migrating to fieldConfigList #14660

Open
clarahong opened this issue Dec 13, 2024 · 1 comment
Labels

Comments

@clarahong
Copy link

clarahong commented Dec 13, 2024

When setting table index configs, Pinot documentation recommends deprecating usage of single-column index configurations in favor of the Field Config List.

However, when attempting to migrate an existing table from the deprecated format, these settings are not respected. For example, using an old table config, dictionary indexes are disabled:

{
  ...
    "tableIndexConfig": {
      "noDictionaryColumns": [
        "col1",
        “range1”,
      ],
      ...
      "optimizeDictionaryForMetrics": true,
      "optimizeDictionary": false,
      "noDictionarySizeRatioThreshold": 0.85
    },
  }

Updating to a new definition:

{
...
  "fieldConfigList": [
    {
      "name": "range1",
      "indexes": {
        "dictionary": {
          "disabled": true
        },
        "range": {}
      }
    },
    {
      "name": "col1",
      "indexes": {
        "dictionary": {
          "disabled": true
        },
        "json": {
          "maxLevels": 1,
          "excludeArray": true,
          "disableCrossArrayUnnest": true
        }
      }
    }
  ]
}

Making the table config change and triggering a table reload creates new dictionary indexes even though they are specified as disabled. Adding the property "encodingType": "RAW" also does not resolve this issue.

@Jackie-Jiang
Copy link
Contributor

Thanks for reporting the issue. I believe this is a bug and should be fixed with #14258. Can you try with the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants