Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolMessage and DLQ can not work together #13269

Open
wangjialing218 opened this issue Dec 13, 2021 · 5 comments · May be fixed by #13280
Open

PoolMessage and DLQ can not work together #13269

wangjialing218 opened this issue Dec 13, 2021 · 5 comments · May be fixed by #13280
Assignees
Labels
help wanted lifecycle/stale Stale type/bug The PR fixed a bug or issue reported a bug

Comments

@wangjialing218
Copy link
Contributor

Describe the bug
PoolMessage and DLQ can not work together

To Reproduce
Steps to reproduce the behavior:

  1. Enable poolMessages and DLQ in consumer side
  2. Call consumer.negativeAcknowledge(message) and then call message.release()
  3. The message did not resend to DLQ topic.

Expected behavior
The message should be sent to DLQ topic.

Additional context
The negative ack msgs will be sent to DLQ topic in a scheduler triggerRedelivery, when we enable poolMessages, message.release() will clear MessageImpl immediately, this will cause processPossibleToDLQ() fail to get message id and resend to DLQ.

@wangjialing218
Copy link
Contributor Author

I'm working on this

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@kamilchociej
Copy link

kamilchociej commented Jul 17, 2024

@hangc0276 @wangjialing218 I noticed that the solution proposed in the pull request for this bug has not been merged yet. Could you please provide an update on its status and let us know when we can expect this bug to be resolved?

@david-streamlio
Copy link
Contributor

It looks like the PR has one commit/change request and some conflicts. Until those are resolved, we cannot merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted lifecycle/stale Stale type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants