[fix][client] Fix ArrayIndexOutOfBoundsException when using SameAuthParamsLookupAutoClusterFailover #23336
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kupAutoClusterFailover
|
Any chance to add a test case? |
Technoboy-
approved these changes
Sep 24, 2024
lhotari
changed the title
@poorbarcode @Technoboy- any chance to handle this? |
lhotari
reviewed
Oct 30, 2024
| @@ -123,7 +130,7 @@ private int firstHealthyPulsarService() { | |||
| } | |||
|
|
|||
| private int findFailoverTo() { | |||
| for (int i = currentPulsarServiceIndex + 1; i <= pulsarServiceUrlArray.length; i++) { | |||
| for (int i = currentPulsarServiceIndex + 1; i < pulsarServiceUrlArray.length; i++) { | |||
There was a problem hiding this comment.
Just wondering if this logic is correct in the first place. Shouldn't this wrap around the array?
the for loop in checkPulsarServices looks strange too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a mistake in
SameAuthParamsLookupAutoClusterFailover.class, which may cause aArrayIndexOutOfBoundsException, but it affects nothing because it only happens when no server is available.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x