[Bug] Pulsar build process seems to require Maven > 3.8.1

[frankjkelly]

Search before asking

• I searched in the issues and found nothing similar.

Read release policy

• I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

$ mvn --version
Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
Maven home: /usr/local/Cellar/maven/3.8.1/libexec
Java version: 17.0.9, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk@17/17.0.9/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.2.1", arch: "x86_64", family: "mac"

Minimal reproduce step

On the master branch of Pulsar using Maven 3.8.1 I ran

$ mvn clean install -DskipTests

it ran successfully without any errors or failures but the binaries locally (in the ./bin folder) were not updated to todays date (Nov 4th 2024)

$ ls -la ./bin/pulsar-client
-rwxr-xr-x  1 xxx  yyy  1075 Dec  1  2022 ./bin/pulsar-client
$  ls -la ./bin/pulsar
-rwxr-xr-x  1 xxx  yyy  17835 Oct 14 09:55 ./bin/pulsar

After I updated to Maven 3.9.9 as per https://pulsar.apache.org/contribute/release-process/#preparation
then the binaries were updated.
If this is accurate then someone needs to update the enforcer-plugin here

pulsar/pom.xml

Lines 2125 to 2127 in 570cb44

	<requireMavenVersion>
	<version>3.6.1</version>
	</requireMavenVersion>

What did you expect to see?

Binaries in ./bin updated

What did you see instead?

Binaries not updated

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[lhotari]

it ran successfully without any errors or failures but the binaries locally (in the ./bin folder) were not updated to todays date (Nov 4th 2024)

When you say that the binaries weren't updated, did this happen in the resulting .tar.gz distribution?
The bin directory is part of the source repository files so I don't see why maven should update the files at all to the source directory.

[frankjkelly]

it ran successfully without any errors or failures but the binaries locally (in the ./bin folder) were not updated to todays date (Nov 4th 2024)

When you say that the binaries weren't updated, did this happen in the resulting .tar.gz distribution? The bin directory is part of the source repository files so I don't see why maven should update the files at all to the source directory.

Sorry the binaries in question are in ./bin directory.
I looked in the distribution/server/target folder and although the .tar.gz was there the binaries were also not in that gzipped archive file.
Once I updated mvn they were then in both locations ./bin and distribution/server/target` (in the archive)

[frankjkelly]

FYI I'm sanity check my report to make sure this is easily reproducible.

[frankjkelly]

UPDATE: Ha ha - please ignore the earlier comment here - I only now realized those are scripts and not actually binaries

[frankjkelly]

Yeah so clearly I was not understanding that the files in ./bin directory were not binaries but scripts and so not generated. Sorry!