[improve][admin] Print error log if handle http response fails #23563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When users are calling
pulsar-admin
API, and there is an internal error( such as a deserialize JSON error), there is no error log.You can test it this way:
TopicStatsImpl
, and return aString
value(such asabc
), which will make theresponse.msgRateIn
as a String valueabc
.pulsar-admin topics stats
Modifications
Print error log if handle HTTP response fails
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x